Skip to content

fix(cli): exit analytics container when migrations fail - #6093

Merged
Coly010 merged 1 commit into
supabase:developfrom
7ttp:fix/logflare-migrate-guard
Aug 6, 2026
Merged

fix(cli): exit analytics container when migrations fail#6093
Coly010 merged 1 commit into
supabase:developfrom
7ttp:fix/logflare-migrate-guard

Conversation

@7ttp

@7ttp 7ttp commented Aug 5, 2026

Copy link
Copy Markdown
Member

TL;DR

fixes the analytics crashloop where a failed Logflare.Release.migrate got silently swallowed and
Logflare booted against an unmigrated database killing
Oban on the missing public.oban_jobs, by chaining migrate && start in the generated entrypoint
so a failed migrate now exits the container and the unless-stopped restart policy
just retries until the db is ready

already broken stacks need one supabase stop && supabase start after upgrading cause the new entrypoint only applies on container recreate. diverges from go (ts only)....

before vs after
BEFORE (db refusing):  migrate fails, app boots anyway, zombie with exit 0
AFTER  (db refusing):  app never boots, container exits and retries
AFTER  (db appears):   migrations apply (37 tables + oban), boots clean

ref:

@7ttp
7ttp requested a review from a team as a code owner August 5, 2026 17:23
@7ttp 7ttp self-assigned this Aug 5, 2026
@7ttp

7ttp commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 000ea3b9e6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@Coly010
Coly010 added this pull request to the merge queue Aug 6, 2026
Merged via the queue into supabase:develop with commit 82f6e05 Aug 6, 2026
22 checks passed
avallete pushed a commit that referenced this pull request Aug 7, 2026
Verified every bullet against the actual v2.111.0..v2.112.0 tree diff
(the range came from a rebased develop rollup, so commit subjects alone
were misleading) and applied the Codex review feedback:

- Drop #6072 and #6080: packages/next-only, not in the stable shell
- Drop #6003 and #6057: the stable CLI does not exercise the stack
  binary cache; #6057's "rollup" was the develop->main rollup PR,
  not the Rollup bundler
- Add breaking-change section for NPM_AUTH_TOKEN no longer being
  forwarded by functions deploy (#6005, ships in this tag)
- Note the one-time stop/start needed for already-stuck stacks (#6093)
- Scope #5956 to functions download path traversal
- Point db pull --experimental users at --declarative (#6028)
- Fix #6065 and #6066 descriptions to match the shipped changes
- Recount the internal tail (33 uncited commits in the compare range)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018h8krKpNet85649nqtj95b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local: analytics container boots against an unmigrated DB — entrypoint ignores failed Logflare.Release.migrate and never waits for supabase_db

2 participants