Conversation
added 3 commits
June 14, 2022 22:53
kangmingtay
requested changes
Jun 14, 2022
migrations/20220614074223_add_ip_address_to_audit_log.postgres.up.sql
Outdated
Show resolved
Hide resolved
kangmingtay
approved these changes
Jun 14, 2022
Contributor
|
🎉 This PR is included in version 2.6.36 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
Add IP Address field to audit log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
In order to support IP address tracking for MFA and SAML we would probably to track IP addresses in our audit log.
Not sure if there are other immediate fields that we should consider adding. Let me know if any others come to mind
What is the current behavior?
No IP Addresses
What is the new behavior?
IP address field in audit log
Additional context
Add any other context or screenshots.