Conversation
added 4 commits
June 15, 2022 15:21
…into j0_add_enable_add_disable
…se/gotrue into j0_add_enable_add_disable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Two simple API endpoints to turn the MFA feature on and off. Calling the endpoints should be idempotent and not throw errors(e.g. calling /enable when it is already on will leave the setting as enabled)
Currently
NewUserdefaults to having MFAEnabled as False because of setting in DB.What is the current behavior?
No toggles for MFA
What is the new behavior?
Can toggle MFA on and off
Additional context
numUserFieldswas updated to account for the new IPAddress field introduced in the AuditLog model.