HAR-7831 - placeholders for empty fields#101
Merged
Merged
Conversation
harbournick
requested changes
Sep 26, 2024
harbournick
left a comment
harbournick
left a comment
Collaborator
There was a problem hiding this comment.
Couple minor tweaks
|
|
||
| onMounted(() => { | ||
| loadDocument(props.fileSource); | ||
| onMounted(async () => { |
Collaborator
There was a problem hiding this comment.
why do we need async here if we aren't awaiting anything?
| @@ -1,66 +1,63 @@ | |||
| <script setup> | |||
| import { defineProps, onMounted, ref } from 'vue'; | |||
| import { defineProps, defineEmits, onMounted, ref } from 'vue'; | |||
Collaborator
There was a problem hiding this comment.
You don't need to explicitly import defineProps or defineEmits - in fact they'll generate a warning. Let's remove them.
| :document-data="doc" | ||
| @selection-change="handleSelectionChange" | ||
| @ready="handlePdfReady" | ||
| @selection-drag="handleSelectionDrag" |
Collaborator
There was a problem hiding this comment.
Did you mean to re-add these emits here? I removed them yesterday. If not, can you remove? If yes, we should figure out why - the selection is now handled in Superdoc.vue now in the viewer.
superdoc-bot Bot
pushed a commit
that referenced
this pull request
Jun 16, 2026
![superdoc-oss-port[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
fix: pen testing issues Note: this ports only the public subtree changes from a mixed source commit (18 public paths, 1 non-public path ignored). Ported-From-Source-Repo: superdoc/orbit Ported-From-Source-Commit: 2a22276578955cc76b38a69d1aedd1252b3f6f0e Ported-Public-Prefix: superdoc/public
superdoc-bot Bot
pushed a commit
that referenced
this pull request
Jul 15, 2026
### Bug Fixes - publish GitHub releases for stable versions only ### Changes - Merge pull request #101 from superdoc/artem/SD-3452 - 🔄 Sync stable → main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
companion to webapp PR: https://github.com/Harbour-Enterprises/Harbour-WebApp/pull/4657
Should also solve: