HAR-7163 - editor core infrastructure#11
Merged
Conversation
artem-harbour
force-pushed
the
artem-editor-v2
branch
from
June 24, 2024 18:07
519010e to
b0f987b
Compare
Contributor
Author
|
FYI @harbournick, @mattConnHarbour - for informational purposes for now. |
artem-harbour
force-pushed
the
artem-editor-v2
branch
3 times, most recently
from
June 27, 2024 14:20
74e4480 to
89f2df8
Compare
artem-harbour
force-pushed
the
artem-editor-v2
branch
from
June 27, 2024 16:32
89f2df8 to
a36b50e
Compare
artem-harbour
changed the title
artem-harbour
marked this pull request as ready for review
June 27, 2024 17:11
artem-harbour
changed the title
harbournick
approved these changes
Jun 27, 2024
harbournick
left a comment
harbournick
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - great infrastructure here to build on top of!
| * @param defaultAttribute Default attribute. | ||
| * @returns Global extension attributes. | ||
| */ | ||
| static #getGlobalAttributes(extensions, defaultAttribute) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear:
https://linear.app/harbour/issue/HAR-7163/core-editor-infrastructure
Implemented most of the core infrastructure for working with the Editor.
Main classes:
src/core/Editor.js)src/core/ExtensionService.js)src/core/CommandService.js)src/core/Schema.js)src/core/Extension.js)src/core/Node.js)src/core/Mark.js)src/core/EventEmitter.js)Created several core extensions, all Node and Mark extensions for building the existing schema.
The schema is now created based on Node and Mark extensions.