Skip to content

feat(ci): run demo tests against local workspace code - #2481

Merged
caio-pizzol merged 3 commits into
mainfrom
caio-pizzol/demos-test-local-workspace
Mar 19, 2026
Merged

feat(ci): run demo tests against local workspace code#2481
caio-pizzol merged 3 commits into
mainfrom
caio-pizzol/demos-test-local-workspace

Conversation

@caio-pizzol

Copy link
Copy Markdown
Contributor

Mirrors the examples approach:

  • Add pnpm overrides for superdoc and @superdoc-dev/react so demos resolve from local workspace instead of npm
  • Add demos/* and demos// to pnpm workspace
  • Rewrite ci-demos workflow: shared build job with pnpm workspace install, expanded path triggers (packages/superdoc, super-editor, layout-engine, react), Playwright browser cache
  • Increase smoke test timeouts for SPA hydration and dev server startup

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea5a1b16dc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/ci-demos.yml
Comment thread .github/workflows/ci-demos.yml
Mirrors the examples approach:
- Add pnpm overrides for superdoc and @superdoc-dev/react so demos
  resolve from local workspace instead of npm
- Add demos/* and demos/*/* to pnpm workspace
- Rewrite ci-demos workflow: shared build job with pnpm workspace
  install, expanded path triggers (packages/superdoc, super-editor,
  layout-engine, react), Playwright browser cache
- Increase smoke test timeouts for SPA hydration and dev server startup
@caio-pizzol
caio-pizzol force-pushed the caio-pizzol/demos-test-local-workspace branch from ea5a1b1 to 2217350 Compare March 19, 2026 22:03
Changes to package.json, pnpm-lock.yaml, or pnpm-workspace.yaml
affect workspace resolution and can break demo installs.
The toolbar demo imports prosemirror-state directly but never declared
it. Worked with npm's flat hoisting but fails with pnpm's strict
module resolution.
@caio-pizzol
caio-pizzol enabled auto-merge (squash) March 19, 2026 22:10
@caio-pizzol
caio-pizzol merged commit 0b550fb into main Mar 19, 2026
23 checks passed
@caio-pizzol
caio-pizzol deleted the caio-pizzol/demos-test-local-workspace branch March 19, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant