feat(ci): run demo tests against local workspace code - #2481
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea5a1b16dc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Mirrors the examples approach: - Add pnpm overrides for superdoc and @superdoc-dev/react so demos resolve from local workspace instead of npm - Add demos/* and demos/*/* to pnpm workspace - Rewrite ci-demos workflow: shared build job with pnpm workspace install, expanded path triggers (packages/superdoc, super-editor, layout-engine, react), Playwright browser cache - Increase smoke test timeouts for SPA hydration and dev server startup
caio-pizzol
force-pushed
the
caio-pizzol/demos-test-local-workspace
branch
from
March 19, 2026 22:03
ea5a1b1 to
2217350
Compare
Changes to package.json, pnpm-lock.yaml, or pnpm-workspace.yaml affect workspace resolution and can break demo installs.
The toolbar demo imports prosemirror-state directly but never declared it. Worked with npm's flat hoisting but fails with pnpm's strict module resolution.
caio-pizzol
enabled auto-merge (squash)
March 19, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the examples approach: