chore(ci): drop merge_group trigger from optional workflows#3036
Merged
Conversation
Only ci-superdoc.yml and ci-behavior.yml are required checks (per the require-ci ruleset). The other 11 workflows are optional and gate themselves by paths on pull_request, but workflow-level paths filters do not apply to merge_group events. Today this is harmless because merge queue is not enabled, but the moment it gets turned on every queue entry would fire all 11 of these regardless of changed paths, multiplying CI cost. Removing merge_group from each so they continue to gate on PR only. The required workflows (ci-superdoc, ci-behavior) keep merge_group since they need to validate the merge candidate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only ci-superdoc.yml and ci-behavior.yml are required checks. The other 11 workflows in .github/workflows/ci-*.yml plus visual-test.yml are optional and gate themselves on pull_request via path filters, but path filters don't apply to merge_group events. Today merge queue isn't enabled so this is harmless, but the moment it gets turned on every queue entry would fire all 11 regardless of changed paths.