fix(super-editor): rethrow export docx errors#3641
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
caio-pizzol
left a comment
There was a problem hiding this comment.
@xy200303 thanks for the fix. I pushed a follow-up commit that covers the SuperDoc wrapper path and avoids duplicate export exception events.
The added coverage checks that a rejected editor export falls back to the original DOCX data, sibling documents still export, and a bridged editor exception does not cause a second wrapper exception.
I only ran git diff --check; local unit tests were not run because this repo asks us not to run them locally. CI is queued.
lgtm.
|
🎉 This PR is included in superdoc-cli v0.17.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.16.0 |
|
🎉 This PR is included in @superdoc-dev/mcp v0.12.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.40.0 The release is available on GitHub release |
|
🎉 This PR is included in @superdoc-dev/react v1.11.0 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.12.0 |
Summary
Editor.exportDocx()errors after preserving the existing exception event and console logging.undefinedfrom the internal implementation return union.converter.exportToDocxcalls reject to the caller.Verification
pnpm test:editor -- src/editors/v1/tests/export/exportDocx.errors.test.jspnpm test:editor -- src/editors/v1/tests/export/exportDocx.errors.test.js src/editors/v1/tests/export/exportDocx.commentsFallback.test.jspnpm --prefix packages/super-editor run types:check(fails: existing unresolved@superdoc/font-systemdeclarations and broad pre-existing JS/TS errors)Closes #3579