fix: rendering and text alignment for textboxes with table content#3716
fix: rendering and text alignment for textboxes with table content#3716VladaHarbour wants to merge 2 commits into
Conversation
|
I wasn't able to run the ecma-spec MCP tools — the environment didn't grant permission for them (I retried; each call returned a pending-permission error). So this review is based on ECMA-376 knowledge rather than live spec lookups. Flagging that up front for transparency. Here's my review of the two changed handler files. Status: PASS Everything these handlers read and emit lines up with ECMA-376. Details:
One non-blocking observation (not failing the review): |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7ffcb41bc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This pull request landed on |
|
🎉 This PR is included in superdoc-cli v0.17.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-sdk v1.16.0 |
|
🎉 This PR is included in @superdoc-dev/mcp v0.12.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.40.0 The release is available on GitHub release |
|
🎉 This PR is included in @superdoc-dev/react v1.11.0 The release is available on GitHub release |
|
🎉 This PR is included in vscode-ext v2.12.0 |
No description provided.