HAR-9454 - handle table colspan and colgroup#464
Merged
Conversation
artem-harbour
force-pushed
the
artem-HAR-9454-v2
branch
3 times, most recently
from
April 22, 2025 09:16
988b066 to
b611d4c
Compare
artem-harbour
changed the title
artem-harbour
commented
Apr 22, 2025
| } | ||
|
|
||
| if (colwidth.length) { | ||
| attributes['colwidth'] = [...colwidth]; |
Contributor
Author
There was a problem hiding this comment.
If the column has colspan greater than 1, then it is important that colwidth attribute has this form [200, 400] (not [600] for colspan 2).
Contributor
Author
There was a problem hiding this comment.
Or [200,300,300] for colspan 3 (not [800]).
artem-harbour
commented
Apr 22, 2025
| gridColumnWidths?.forEach((width) => { | ||
| colgroup?.forEach((width) => { | ||
| elements.push({ | ||
| name: 'w:gridCol', |
Contributor
Author
There was a problem hiding this comment.
It is important to save w:gridCol element for the table, it was not saved before. Now we generate the same values that were for the table node in the editor.
Contributor
Author
|
@harbournick this is ready for review. |
artem-harbour
marked this pull request as ready for review
April 22, 2025 14:40
artem-harbour
force-pushed
the
artem-HAR-9454-v2
branch
from
April 23, 2025 08:46
b611d4c to
aa1b69a
Compare
artem-harbour
force-pushed
the
artem-HAR-9454-v2
branch
from
April 23, 2025 08:49
aa1b69a to
ac847aa
Compare
superdoc-bot Bot
pushed a commit
that referenced
this pull request
Jul 13, 2026
…IT-1278) (#464) * fix(super-editor): drop superseded deferred comment SELECTED events (IT-1278) * fix(super-editor): cancel pending SELECTED timer and report matched highlight ids (IT-1278) * test(behavior): trim comment-id tokens in IT-1278 highlight matching Note: this ports only the public subtree changes from a mixed source commit (2 public paths, 1 non-public path ignored). Ported-From-Source-Repo: superdoc/orbit Ported-From-Source-Commit: c50dfbe779bd87d5b4dcb2f86e3d42e12cf5967e Ported-Public-Prefix: superdoc/public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.