-
Notifications
You must be signed in to change notification settings - Fork 12
feat: wire blast-radius to /v1/analysis/impact endpoint #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonathanpopham
merged 6 commits into
supermodeltools:main
from
jonathanpopham:feat/impact-api-endpoint
Apr 3, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9991bad
feat: wire blast-radius to /v1/analysis/impact endpoint
jonathanpopham ebce1bc
fix(lint): address gocritic rangeValCopy and goimports alignment
jonathanpopham a110909
test: add unit and integration tests for blast-radius
jonathanpopham b2cec55
docs: add docstring to printResults
jonathanpopham dfcd289
fix: include targets in idempotency key to avoid cached collisions
jonathanpopham dbfb150
fix(lint): pass Options by pointer to avoid hugeParam gocritic warning
jonathanpopham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL encoding missing for
targetsquery param — could break with special charactersHey, so if someone passes a file path with spaces or special characters (like
src/my file.tsorsrc/foo&bar.ts), this will produce a malformed URL. Thetargetsstring is concatenated directly without escaping.Quick example of what goes wrong:
targets = "src/my file.ts"/v1/analysis/impact?targets=src/my file.ts(broken URL)You'll want to use
url.QueryEscape(targets)or build the URL properly withurl.Values.🐛 Proposed fix
🤖 Prompt for AI Agents