Move server-side fetch responsibility to adapters instead of build step#1066
Merged
Rich-Harris merged 4 commits intomasterfrom Apr 17, 2021
Merged
Move server-side fetch responsibility to adapters instead of build step#1066Rich-Harris merged 4 commits intomasterfrom
fetch responsibility to adapters instead of build step#1066Rich-Harris merged 4 commits intomasterfrom
Conversation
Member
|
This is great. We also need global I almost wonder if we should expose that module to adapters somehow, rather than expecting them all to include that block correctly. It would also prevent things like version mismatches between dev and prod. Re userland, I think it's solved by this PR? If |
This was referenced Apr 22, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative PR to #1034.
fetchis assumed to be provided by the environment, polyfilled by adapters if unavailablenode-fetchas wellcross-fetchpolyfillNotes:
Use offetchinside server endpoints - do we want to re-exportnode-fetchor is this a userland problem?Endpoints now have de-facto access to global
fetch