Skip to content

fix: set path: '/' in demo#11495

Merged
Rich-Harris merged 2 commits intomainfrom
grich/demo-path
Jan 8, 2024
Merged

fix: set path: '/' in demo#11495
Rich-Harris merged 2 commits intomainfrom
grich/demo-path

Conversation

@geoffrich
Copy link
Copy Markdown
Member

@geoffrich geoffrich commented Jan 1, 2024

We recommend path: '/' for most cases in the docs, but the demo uses path: '' instead. I think it's better to be consistent.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 1, 2024

🦋 Changeset detected

Latest commit: a09f8e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 560b340 into main Jan 8, 2024
@Rich-Harris Rich-Harris deleted the grich/demo-path branch January 8, 2024 16:22
@github-actions github-actions Bot mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants