create-svelte: add svelte-check for TS#1556
Merged
dummdidumm merged 3 commits intomasterfrom May 28, 2021
Merged
Conversation
This add svelte-check along with two validate scripts to the package.json if the user selects TS. This uncovered missing type definitions for the cookie package in the default template, which are now added as well if the user selects TS.
benmccann
reviewed
May 26, 2021
ignatiusmb
reviewed
May 26, 2021
ignatiusmb
approved these changes
May 26, 2021
Member
ignatiusmb
left a comment
ignatiusmb
left a comment
There was a problem hiding this comment.
Really nice addition, especially for TS users
benmccann
approved these changes
May 26, 2021
Member
benmccann
left a comment
benmccann
left a comment
There was a problem hiding this comment.
lgtm. only reason I'm not merging is in case you wanted more opinions on how to setup the package.json commands first. but if you're happy with how it is then I'd say go ahead and hit the green button
Member
Author
|
I'll wait a little more, also because there's likely a new major version of |
sidharthv96
added a commit
to sidharthv96/kit
that referenced
this pull request
May 29, 2021
* 'master' of https://github.com/sveltejs/kit: Version Packages (next) (sveltejs#1543) type fixes for adapter-node and adapter-static (sveltejs#1578) Upgrade to Vite 2.3.3 (sveltejs#1580) fix: improve getRawBody parsing & handle error(s) (sveltejs#1528) create-svelte: add svelte-check for TS (sveltejs#1556) pass validated svelte config to adapters (sveltejs#1559) types: group related and reduce potential inconsistencies (sveltejs#1539) Use sveltekit tag on StackOverflow (sveltejs#1558) Fix create-svelte build-template script (sveltejs#1555) Remove err param from Polka .listen() callback (sveltejs#1550) bump: polka and sirv versions (sveltejs#1548) svelte-kit package (sveltejs#1499)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add svelte-check along with two validate scripts to the package.json if the user selects TS. This uncovered missing type definitions for the cookie package in the default template, which are now added as well if the user selects TS.
Closes #1536 , if noone has objections to doing it this way. Alternatives:
svelte-kit. This would add needless dependencies for those who don't want to use it, and does not bring any benefit to me as it only hides the invocation and cannot add any deeper integrationsvelte-checkis always invoked prior tosvelte-kit. I'm slightly in favor of this, but it slows down the build a little obviously