allow customisation of HOST and PORT env vars in adapter-node#1754
Merged
Conduitry merged 6 commits intosveltejs:masterfrom Jun 24, 2021
Merged
allow customisation of HOST and PORT env vars in adapter-node#1754Conduitry merged 6 commits intosveltejs:masterfrom
Conduitry merged 6 commits intosveltejs:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 0185aaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dominikg
reviewed
Jun 24, 2021
Rich-Harris
reviewed
Jun 24, 2021
Rich-Harris
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1752.
I'm definitely open to other names for this configuration, because I'm not thrilled on what I currently have. If someone has a better idea of what to say in the adapter's readme, I'd also like to hear about that.
Before submitting the PR, please make sure you do the following
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts