fix: include esbuild config in adapter type definition#1954
fix: include esbuild config in adapter type definition#1954
Conversation
🦋 Changeset detectedLatest commit: 6494d96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Fixes #1958 I think |
| * @param {{ | ||
| * esbuild?: (defaultOptions: BuildOptions) => Promise<BuildOptions> | BuildOptions; | ||
| * }} options | ||
| * }} [options] |
There was a problem hiding this comment.
Is this an intentional change? Why only on some adapters?
There was a problem hiding this comment.
adapter-cloudflare-workers,adapter-vercel,adapter-netlify, andadapter-nodeall use esbuild, so this option should be available but not made mandatory.adapter-beginis unmaintainedadapter-staticdoesn't use esbuild, so it wasn't affected.
If you're referring to the specific line, that's JSDoc's way of specifying an optional parameter so that you can do something like adapter: adapterCfw() without having to pass in an empty object.
There was a problem hiding this comment.
If you're referring to the specific line, that's JSDoc's way of specifying an optional parameter so that you can do something like
adapter: adapterCfw()without having to pass in an empty object.
I was referring to the specific line, thanks for clarifying. I need to learn the JSDoc spec better.
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0