[fix] handle paths consistently between dev and various production adapters

[benmccann]

fixes #2166

dev and adapter-node were passing decoded paths while the other adapters were passing the encoded path sent by the browser

The way to handle the path is to split it on forward slashes and then call decodeURIComponent on each path component. That allows you to handle edge cases like %2f. Luckily, that's what build is currently doing:

kit/packages/kit/src/core/build/index.js

Line 614 in c3ca3fb

function get_params(array) {

Otherwise, we shouldn't touch the path. We should just leave it alone and pass along exactly what we received, which is exactly how Express behaves

Previously there was another bug because we were doing decodeURI followed by decodeURIComponent which would cause each component to be double-decoded. By leaving the path alone we don't run into this issue

[changeset-bot]

🦋 Changeset detected

Latest commit: 64087f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@sveltejs/adapter-node	Patch
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Rich-Harris]

I'm not totally sure I understand the scope of this change. Before, we had this:

With this PR, we now have this:

Is that intentional?

[benmccann]

Yeah, I think it's the better behavior to return the path as it was received. There are some edge cases that are impossible to handle otherwise. E.g. see this post where Netlify started out giving users the decoded path and had to switch: https://answers.netlify.com/t/bug-fix-url-encoding-preserved-in-function-event/27080. This is also inline with how Express and most other libraries work, so I think it's generally more expected as well

[Rich-Harris]

Ah, gotcha. That makes sense