Fixing minor syntax issue in example#2
Closed
TehShrike wants to merge 2 commits intosveltejs:reactive-assignmentsfrom
Closed
Fixing minor syntax issue in example#2TehShrike wants to merge 2 commits intosveltejs:reactive-assignmentsfrom
TehShrike wants to merge 2 commits intosveltejs:reactive-assignmentsfrom
Conversation
Conduitry
approved these changes
Nov 2, 2018
Member
|
I would have just merged this in if I wasn't worried about it throwing off Rich when he went to push more commits to a branch that had changed. Maybe for tiny things like this use the new ```suggestion feature in PR comments? |
Member
Author
|
Oh yeah, I forgot about that new feature
Josh
…________________________________
From: Conduitry <notifications@github.com>
Sent: Friday, November 2, 2018 15:55
To: sveltejs/rfcs
Cc: Josh Duff; Author
Subject: Re: [sveltejs/rfcs] Fixing minor syntax issue in example (#2)
I would have just merged this in if I wasn't worried about it throwing off Rich when he went to push more commits to a branch that had changed. Maybe for tiny things like this use the new ```suggestion feature in PR comments?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABFsbY8eUCENvL8sB4c49Ei8wf985B7aks5urLFEgaJpZM4YMDhx>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assuming that the function is supposed to return an object