Skip to content

Fixing minor syntax issue in example#2

Closed
TehShrike wants to merge 2 commits intosveltejs:reactive-assignmentsfrom
TehShrike:patch-1
Closed

Fixing minor syntax issue in example#2
TehShrike wants to merge 2 commits intosveltejs:reactive-assignmentsfrom
TehShrike:patch-1

Conversation

@TehShrike
Copy link
Copy Markdown
Member

Assuming that the function is supposed to return an object

@Conduitry
Copy link
Copy Markdown
Member

I would have just merged this in if I wasn't worried about it throwing off Rich when he went to push more commits to a branch that had changed. Maybe for tiny things like this use the new ```suggestion feature in PR comments?

@TehShrike
Copy link
Copy Markdown
Member Author

TehShrike commented Nov 2, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants