Skip to content

Refactor and consolidate Angular Code Generator#526

Merged
HugoMario merged 2 commits into
swagger-api:masterfrom
hypery2k:improved_angular_support
Nov 6, 2019
Merged

Refactor and consolidate Angular Code Generator#526
HugoMario merged 2 commits into
swagger-api:masterfrom
hypery2k:improved_angular_support

Conversation

@webron

webron commented Oct 31, 2019

Copy link
Copy Markdown

Thanks for the submission, @hypery2k. In case you're not familiar with the option - https://github.blog/2019-02-14-introducing-draft-pull-requests.

@hypery2k

hypery2k commented Nov 1, 2019

Copy link
Copy Markdown
Contributor Author

oh thanks, didn't notice that possibility on GitHub ;)
Thanks for the hint

@hypery2k

hypery2k commented Nov 1, 2019

Copy link
Copy Markdown
Contributor Author

From my tests so far the generation with Angular 6 and 8 is working without issues.

I would like to see this PR merged and will add further functionality in another PR, ok for you @webron ?

@webron

webron commented Nov 1, 2019

Copy link
Copy Markdown

I leave the PR reviews to @HugoMario and @frantuma - they are way more familiar with the code here than me ;)

@HugoMario

Copy link
Copy Markdown
Contributor

LGTM, thanks a lot @hypery2k!!! for this PR

@HugoMario HugoMario merged commit 74593ee into swagger-api:master Nov 6, 2019
@hypery2k hypery2k deleted the improved_angular_support branch November 6, 2019 18:40

@victorsempere victorsempere left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Maybe it's missing a change in the api.service.mustache? I'm getting compilation errors and I have fixed it changing the line 279:
let formParams: { append(param: string, value: any): void; };
Into:
let formParams: { append(param: string, value: any): any; };

I'm using swagger-codegen-maven-plugin 3.0.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[typescript-angular] Angular 7: An expression of type 'void' cannot be tested for truthiness

4 participants