Feature/issue 11123#11168
Open
heissb2342 wants to merge 6 commits into
Open
Conversation
added 6 commits
September 21, 2021 13:40
…er as running `composer install` in sample repository fails otherwise
…ing https scheme led to failing to failing tests
…s removed in update to guzzle 7.3
heissb2342
force-pushed
the
feature/issue_11123
branch
from
50bf2d7 to
0e4c567
Compare
|
Could somebody take a look on this PR? |
|
Any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
fix #11123:
Updated guzzle to version 7.3 in composer.json and made sure, all existing tests ran successfully. To run the tests an update of the spec file used to generate the PHP petstore as well as a spinning method to make sure the changes done by the test were persisted was necessary. I also found another GuzzleHttp\PSR7 method (try_fopen) that needed to be replaced by its static counterpart for 7.3 (GuzzleHttp\PSR7 2.0). Also to be able to run
composer installI needed to adapt the dummy values for gitUserId and gitRepoId in CodegenConfigurator to conform with composer 2.0 standards. This should not break anything for composer 1.* users but fixes the petstore client if one uses composer 2.0.@mandrean @dkarlovi Please review, as this targets PHP in particular ;)