Skip to content

[php] support guzzlehttp/guzzle ^7.0#11773

Open
oprudkyi wants to merge 3 commits into
swagger-api:3.0.0from
oprudkyi:fix/php-guzzlehttp-7
Open

[php] support guzzlehttp/guzzle ^7.0#11773
oprudkyi wants to merge 3 commits into
swagger-api:3.0.0from
oprudkyi:fix/php-guzzlehttp-7

Conversation

@oprudkyi

Copy link
Copy Markdown

PR checklist

  • [ x] Read the contribution guidelines.
  • [ x] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [ x] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [ x] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@dkarlovi (2017/07) @mandrean (2017/08)

Description of the PR

php sample regenerated based on swagger-api/swagger-codegen-generators#1040

@oprudkyi oprudkyi force-pushed the fix/php-guzzlehttp-7 branch from b6a4bfe to f3eaf33 Compare May 11, 2022 02:36
@oprudkyi

Copy link
Copy Markdown
Author

@frantuma @HugoMario Could you please help to merge this ?

@chrillep chrillep mentioned this pull request Jun 18, 2022
4 tasks
@andythedandy

Copy link
Copy Markdown

I would tottaly merge this!

@sharovik

Copy link
Copy Markdown

Should we release this one?

@sharovik

Copy link
Copy Markdown

Hey @frantuma, do you have the rights to merge and build this one?

@sharovik

Copy link
Copy Markdown

Actually, I see the code in this PR is not a mustache change. So it wont work

@sharovik sharovik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change the mustache code, instead you changed the sample

@oprudkyi

Copy link
Copy Markdown
Author

@sharovik mustache code was changed in swagger-api/swagger-codegen-generators#1040

@sharovik

Copy link
Copy Markdown

Oh. I see. :(

@riccafi

riccafi commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

Are there some progresses about this pull request?
It would be fantastic to have this update!

Thank you all :-)

@Axent96

Axent96 commented Mar 22, 2023

Copy link
Copy Markdown

@riccafi @andythedandy @oprudkyi some plans to merge the issue?

@sharovik

Copy link
Copy Markdown

I believe this may be helpful for everyone here.
So, take the mustache files from this PR https://github.com/swagger-api/swagger-codegen-generators/pull/1040/files
And when you build your SDK, use the next arguments: --template-dir="${MUSTACHE_TEMPLATE_PATH}" --template-engine="mustache"

Where MUSTACHE_TEMPLATE_PATH is the path, where you placed these files.

So you will have something like this:

swagger-codegen generate --template-dir="MUSTACHE_TEMPLATE_PATH" --template-engine="mustache" -i "path/to/your/api-docs.json" -l php -o "OUTPUT_PATH" -c "SWAGGER_CONFIG_PATH" 

@Axent96

Axent96 commented May 30, 2023

Copy link
Copy Markdown

We need the fix ASAP or we can drop php support from the generator. guzzlehttp/guzzle v6 is deprecated a long time

@HugoMario

Copy link
Copy Markdown
Contributor

addressed by swagger-api/swagger-codegen-generators#1040

@HugoMario HugoMario closed this May 31, 2023
@HugoMario HugoMario reopened this May 31, 2023
@katsew

katsew commented Mar 18, 2025

Copy link
Copy Markdown

Hi. I drop in here from #11123.
Any update?
My generated code generated by the latest docker container still using guzzle 6.2 in composer.json.

@frantuma frantuma force-pushed the 3.0.0 branch 6 times, most recently from c824674 to 7e5274a Compare June 23, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants