[php] support guzzlehttp/guzzle ^7.0#11773
Conversation
b6a4bfe to
f3eaf33
Compare
|
@frantuma @HugoMario Could you please help to merge this ? |
|
I would tottaly merge this! |
|
Should we release this one? |
|
Hey @frantuma, do you have the rights to merge and build this one? |
|
Actually, I see the code in this PR is not a mustache change. So it wont work |
sharovik
left a comment
There was a problem hiding this comment.
You need to change the mustache code, instead you changed the sample
|
@sharovik mustache code was changed in swagger-api/swagger-codegen-generators#1040 |
|
Oh. I see. :( |
|
Are there some progresses about this pull request? Thank you all :-) |
|
@riccafi @andythedandy @oprudkyi some plans to merge the issue? |
|
I believe this may be helpful for everyone here. Where MUSTACHE_TEMPLATE_PATH is the path, where you placed these files. So you will have something like this: swagger-codegen generate --template-dir="MUSTACHE_TEMPLATE_PATH" --template-engine="mustache" -i "path/to/your/api-docs.json" -l php -o "OUTPUT_PATH" -c "SWAGGER_CONFIG_PATH" |
|
We need the fix ASAP or we can drop php support from the generator. guzzlehttp/guzzle v6 is deprecated a long time |
|
addressed by swagger-api/swagger-codegen-generators#1040 |
|
Hi. I drop in here from #11123. |
c824674 to
7e5274a
Compare
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.@dkarlovi (2017/07) @mandrean (2017/08)
Description of the PR
php sample regenerated based on swagger-api/swagger-codegen-generators#1040