[TS][Fetch] Handle query parameters containing colons#4287
Merged
Conversation
Put query parameters between quotes and access object keys using square brackets to make sure special characters are handled in parameter names. Closes #4284
Contributor
|
@ChrisJamesC thanks for the PR. The change looks good to me. Please rebase on the latest master when you've time. We might need to apply the same fix to other typescript generators (node, angular, angular2) cc @Vrolijkx |
# Conflicts: # modules/swagger-codegen/src/main/resources/TypeScript-Fetch/api.mustache # samples/client/petstore/typescript-fetch/builds/default/api.ts # samples/client/petstore/typescript-fetch/builds/es6-target/api.ts # samples/client/petstore/typescript-fetch/builds/with-npm-version/api.ts
Contributor
Author
|
@wing328 I updated the branch from master. Please let me know if there is anything I can do. |
Contributor
|
@wing328 This fix is little bigger in the angular2 version |
Contributor
wing328
changed the title
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
…ns (swagger-api#4287) Put query parameters between quotes and access object keys using square brackets to make sure special characters are handled in parameter names. Closes swagger-api#4284
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put query parameters between quotes and access object keys using square
brackets to make sure special characters are handled in parameter
names.
Closes #4284