[Typescript][Angular] Added in injected basePath observable to api service to allow it to respond to external updates to this setting post construction.#7965
Closed
chrismellard wants to merge 7 commits into
Conversation
…espond to external updates to this setting post construction. Added in injected basePath observable to api service to allow it to respond to external updates to this setting post construction.
Author
Contributor
|
@chrismellard thanks for the PR. would you mind adding a note to the Readme.moustache or add a description of the constructor variable? |
Contributor
|
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) |
Contributor
|
Will check tomorrow! |
…H_OBSERVABLE DI token
Author
|
@macjohnny Sure. Just pushed an update to the README.mustache file with some example usage. |
4 tasks
Contributor
|
@wing328 could you please restart the CircleCI tests? |
Contributor
|
You can just close and reopen the PR to trigger CI.
Esteban Marin <notifications@github.com> schrieb am Do., 19. Apr. 2018
07:25:
… @wing328 <https://github.com/wing328> could you please restart the
CircleCI tests?
@chrismellard <https://github.com/chrismellard> could you please merge
the current master into your branch and re-generate the samples?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7965 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFs3Z1-HU8gJ5S5-cAqkAt-iupGAxSzGks5tqB-1gaJpZM4TGiDx>
.
|
macjohnny
reviewed
May 13, 2018
macjohnny
left a comment
macjohnny
left a comment
Contributor
There was a problem hiding this comment.
Use the ‚{#useRxJs6}‘ variable
Author
|
Thanks - will update now |
4 tasks
|
Any reason why this is not merged yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
Fixes #7949
Extended api service to allow optional injection of an observable basePath. This facilitates configuration of basePath post service construction which is required in circumstances where runtime setting of basePath cannot be achieved using APP_INITIALIZER tokens in angular. One such use case is when using libraries such as ngrx effects that do not respect such angular APP_INITIALIZER tokens.
Another option is to simply include the injected observable as part of the Configuration class rather than a separate dependency injectable token. If its preferable to move it inside that class I can do so.