Skip to content

Unit tests for swagger-models module to increase code coverage from 15% to 99%#1585

Merged
fehguy merged 3 commits into
swagger-api:masterfrom
DevFactory:df-unit-tests-swagger-models
Jan 6, 2016
Merged

Unit tests for swagger-models module to increase code coverage from 15% to 99%#1585
fehguy merged 3 commits into
swagger-api:masterfrom
DevFactory:df-unit-tests-swagger-models

Conversation

@mfarid

@mfarid mfarid commented Jan 3, 2016

Copy link
Copy Markdown

This pull request is focused on module swagger-models. Code coverage is measured using JaCoCo. This pull request increases code coverage of this module by 84%.

Metric Before After
Coverage % 15.90% 99.40%
Lines Covered 586 3651
Total Lines 3673 3673

Please let me know if you have any questions.

This PR is a team effort from @chomnoue and @mfarid.

Mohd Farid
DevFactory - Code Quality Team

Signed-off-by: mfarid mohd.farid@devfactory.com

Michel Chomnoue and others added 3 commits January 3, 2016 06:48
@fehguy

fehguy commented Jan 4, 2016

Copy link
Copy Markdown
Contributor

Hi, are these automatically generated?

@mfarid

mfarid commented Jan 4, 2016

Copy link
Copy Markdown
Author

Hi @fehguy

These changes are not generated automatically. These are written carefully by analysing the existing gaps in the code coverage and addressing those.

This entire Pull Request has undergone:

  • Multiple iterations of extensive code reviews by Senior Architects
  • Code quality checks by internal Continuous Integration Server

Here are some examples of similar contributions made by our team:

Please let me know in case of any questions.

Thank you
Farid

fehguy added a commit that referenced this pull request Jan 6, 2016
Unit tests for swagger-models module to increase code coverage from 15% to 99%
@fehguy fehguy merged commit 43c7f2a into swagger-api:master Jan 6, 2016
@fehguy fehguy added this to the v1.5.6 milestone Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants