This PR allows additional configuration to be use in swagger-ui-react#5456
Closed
tompahoward wants to merge 3 commits into
Closed
This PR allows additional configuration to be use in swagger-ui-react#5456tompahoward wants to merge 3 commits into
tompahoward wants to merge 3 commits into
Conversation
Contributor
|
@tompahoward: we're going to pass on this PR for now, as we've intentionally been avoiding passing all prop options to the constructor, as we want to build out a better way to dynamically set configuration options (likely via expanding the that being said, as you mentioned that I'm going to close this out, but thank you for the contribution regardless! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only a few Swagger UI configuration options are available in swagger-ui-react.
This PR makes them all available
Description
Previously only individual configuration options were mapped from swagger-ui-react to swagger-ui. This PR fixes that.
Motivation and Context
I needed to set the
supportedSubmitMethodsconfiguration option when using swagger-ui with react.How Has This Been Tested?
I ran
npm run testfrom the rootScreenshots (if appropriate):
🤷♂️
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests