Skip to content

upgrade to caravan from (deprecated) unchained-bitcoin, add taproot support #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turkycat merged 8 commits into from
Mar 11, 2025
Merged

upgrade to caravan from (deprecated) unchained-bitcoin, add taproot support #61

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5ac1675
upgrade to caravan from (deprecated) unchained-bitcoin, add taproot t…
turkycat Mar 4, 2025
65f54ea
correct the description of one of the new tests
turkycat Mar 4, 2025
35c9ffe
add a few more taproot tests
turkycat Mar 4, 2025
98e39d2
removed xpub tool and components, upgraded node to v20, updated bitco…
bertonjulian Mar 5, 2025
86b5ff7
added path tests for Taproot
bertonjulian Mar 5, 2025
cd50bb3
Merge branch 'master' into jdf/caravan-upgrade
bertonjulian Mar 5, 2025
30d1b94
add taproot support to xpub-cli, fix some cli bugs
turkycat Mar 5, 2025
dec8e96
convert xpub cli from using module syntax
turkycat Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added path tests for Taproot
  • Loading branch information
@bertonjulian
bertonjulian committed Mar 5, 2025
commit 86b5ff70bef49c5a4e8b23df90cd2a34b48e7fee
1 change: 1 addition & 0 deletions packages/xpub-lib/src/derivation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ function deriveAddress({ purpose, pubkey, network }) {
return bc1qAddress
}
case Purpose.P2TR: {
Copy link

@ramontayag ramontayag Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

// Context: https://bitcoinops.org/en/topics/x-only-public-keys/
const xOnlyPubkey = toXOnly(pubkey)
const { address: bc1pAddress } = bitcoin.payments.p2tr({
internalPubkey: xOnlyPubkey,
Expand Down
10 changes: 10 additions & 0 deletions packages/xpub-lib/src/paths.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ describe("accountDerivationPath", () => {
expect(
accountDerivationPath({ purpose: Purpose.P2WPKH, accountNumber: 0 })
).toBe("m/84'/1'/0'")
expect(
accountDerivationPath({ purpose: Purpose.P2TR, accountNumber: 0 })
).toBe("m/86'/1'/0'")
expect(
accountDerivationPath({ purpose: Purpose.P2PKH, accountNumber: 1337 })
).toBe("m/44'/1'/1337'")
Expand All @@ -86,6 +89,13 @@ describe("accountDerivationPath", () => {
network: Network.MAINNET,
})
).toBe("m/84'/0'/0'")
expect(
accountDerivationPath({
purpose: Purpose.P2TR,
accountNumber: 0,
network: Network.MAINNET,
})
).toBe("m/86'/0'/0'")
expect(
accountDerivationPath({
purpose: Purpose.P2WPKH,
Expand Down
Loading