parser: assertion failed: span.lo >= self.input.start_pos() && span.hi <= self.input.end_pos()

[Boshen]

Describe the bug

  thread 'main' (2474) panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/swc_ecma_parser-29.0.0/src/lexer/state.rs:77:9:
  assertion failed: span.lo >= self.input.start_pos() && span.hi <= self.input.end_pos()

Input code

Config

Link to the code that reproduces this issue

https://github.com/oxc-project/bench-javascript-parser-written-in-rust/actions/runs/19917146865/job/57098419563?pr=425

SWC Info output

No response

Expected behavior

parse

Actual behavior

No response

Version

28.0.0 -> 29.0.0

Additional context

No response

[kdy1]

Thanks for reporting!

[CPunisher]

Investigation:

https://github.com/oxc-project/bench-javascript-parser-written-in-rust/blob/main/src/lib.rs#L29
The benchmark manually create StringInput with start_pos = 0 and end_pos = 0, thus breaking the assertion. Changing it to let input = StringInput::new(source, BytePos(0), BytePos(source.len() as u32)) solves the problem. However, this also makes the ast span starts from 0 instead 1.

Ah, I'm not sure whether the root cause is incorrect API usage, an bad-designed API, or whether the assertion here is written correctly.

[kdy1]

I think assertion should be in the creator function of StringInput