Move away from resource helper.#131
Closed
Diggory wants to merge 6 commits into
Closed
Conversation
Use Bundle.module methods to load the test files.
Use Bundle.module methods to load the test files.
…ry/SwiftCSV into MoveAwayFromResourceHelper
Diggory
changed the title
Contributor
|
The CSV file copy phase looks nice! Could you double check that the Xcode Project in the SwiftCSV still compiles and tests? I believe you need to switch between |
Contributor
Author
|
Ah! I didn't check the Xcode project. I now have a separate branch which solves that (and brings back ResourceHelper.) I will close this PR and generate another one from that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates swift tools version in manifest to 5.5
Moves test sample files into their own directory.
Removes ResourceHelper and uses built-in function for getting resources as offered by SPM since 5.5
Fixes #130