Implement function bodies for lowered @_cdecl thunks#212
Merged
DougGregor merged 2 commits intoJan 30, 2025
Conversation
Improve the handling of lowering Swift declarations down to C thunks to more clearly model the mapping between the C parameters and the Swift parameters, and start generating code within the body of these C thunks. Provide tests and fixes for lowering of methods of structs and classes, including mutating methods, as well as inout parameters, direct and indirect returns, and so on.
ktoso
reviewed
Jan 30, 2025
| case .enum, .struct, .protocol: loweringStep = .passIndirectly(parameterName) | ||
| case .actor, .class: | ||
| loweringStep = | ||
| .unsafeCastPointer(.passDirectly(parameterName), swiftType: type) |
Collaborator
There was a problem hiding this comment.
Oh nice, I like this idea of constructing what we need to do like that
ktoso
reviewed
Jan 30, 2025
| /// Produce the `@_cdecl` thunk for this lowered function signature that will | ||
| /// call into the original function. | ||
| @_spi(Testing) | ||
| public func cdeclThunk(cName: String, inputFunction: FunctionDeclSyntax) -> FunctionDeclSyntax { |
ktoso
approved these changes
Jan 30, 2025
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Really cool work here, looking good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the handling of lowering Swift declarations down to C thunks to more clearly model the mapping between the C parameters and the Swift parameters, and start generating code within the body of these C thunks. Provide tests and fixes for lowering of methods of structs and classes, including mutating methods, as well as inout parameters, direct and indirect returns, and so on.