[JExtract/JNI] Omit unsupported types instead of crashing#313
Merged
Conversation
ktoso
reviewed
Jul 13, 2025
ktoso
reviewed
Jul 13, 2025
ktoso
reviewed
Jul 13, 2025
ktoso
reviewed
Jul 13, 2025
Collaborator
|
Minor log level nitpick. Does the FFM mode already do the same? Can we add the same “test” (just a decl we ignore) in FFM? |
Contributor
Author
|
@ktoso Yes FFM should also ignore any unsupported types, but I also added a unsupported type to the FFM sample app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omits any unsupported types such as
UInt8instead of crashing the generation.