Skip to content

Prepare accessor function descriptors for properties: get set#41

Merged
ktoso merged 5 commits into
swiftlang:mainfrom
ktoso:wip-properties
Oct 8, 2024
Merged

Prepare accessor function descriptors for properties: get set#41
ktoso merged 5 commits into
swiftlang:mainfrom
ktoso:wip-properties

Conversation

@ktoso
Copy link
Copy Markdown
Collaborator

@ktoso ktoso commented Oct 3, 2024

Started progress on variables/properties.

  • function descriptors
  • addresses
  • getter downcall method
  • setter downcall method
  • filter out async/throwing etc
  • computed properties

Just the function descriptors for now, will do the complete thing in this PR.

Resolves #24

@ktoso ktoso force-pushed the wip-properties branch 2 times, most recently from 20e3f76 to 9ca8ff6 Compare October 3, 2024 13:13
Comment thread Package.swift
.package(url: "https://github.com/apple/swift-argument-parser", from: "1.5.0"),
.package(url: "https://github.com/apple/swift-system", from: "1.0.0"),
.package(url: "https://github.com/apple/swift-system", from: "1.0.0"), // TODO: remove, we should not need 'nm' or process callouts
.package(url: "https://github.com/apple/swift-collections.git", .upToNextMinor(from: "1.1.0")),
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OrderedSet to avoid sourcegen order breaking some tests

}

@Test
@DisabledOnOs(OS.LINUX) // FIXME: enable on Linux when we get new compiler with mangled names in swift interfaces
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of tests waiting on #27

@ktoso ktoso merged commit 6edcde5 into swiftlang:main Oct 8, 2024
@ktoso ktoso deleted the wip-properties branch October 8, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jextract-swift support Swift properties as Java get/set method pairs

1 participant