jextract: pass arena from Swift instead of default interface for callbacks#489
Merged
Merged
Conversation
ktoso
reviewed
Dec 10, 2025
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Let's clean this up some more while at it, goal looks good tho
ktoso
reviewed
Dec 10, 2025
ktoso
approved these changes
Dec 10, 2025
ktoso
added a commit
to ktoso/swift-java
that referenced
this pull request
Dec 19, 2025
…for callbacks (swiftlang#489)" This reverts commit acff3ee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we generated
defaultmethods for the Java interface methods that require aSwiftArena. That was a way to basically use a global arena, instead of passing in one from Swift.I think this PR is a better solution, where we pass in the global arena from Swift (a global cached ref) and not generate the default methods, unless the user has explicitly requested it through the
allowGlobalArenamemory management mode.