make SwiftJava a dynamic lib and add class lookup fallbacks#493
Merged
Conversation
ktoso
reviewed
Dec 11, 2025
ktoso
reviewed
Dec 11, 2025
ktoso
reviewed
Dec 11, 2025
| // Called by generated code, and not automatically by Java. | ||
| public func _JNI_OnLoad(_ javaVM: JavaVMPointer, _ reserved: UnsafeMutableRawPointer) { | ||
| @_cdecl("JNI_OnLoad") | ||
| func SwiftJava_JNI_OnLoad(javaVM: JavaVMPointer, reserved: UnsafeMutableRawPointer) -> jint { |
Collaborator
There was a problem hiding this comment.
don't we need this "lower", in a lib that does not have macros?
ktoso
added a commit
to ktoso/swift-java
that referenced
this pull request
Dec 19, 2025
…swiftlang#493)" This reverts commit 0685f55.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
SwiftJavato a dynamic lib, that will be loaded in the JExtract libs. This will always us to tap intoJNI_OnLoadto get the shared JVM, and also cache the application class loader, so that we can use that as a fallback in thewithJNIClass, if for example running on a native thread.Resolves #419