Reorganize build: SwiftKit has "swift kit" core, and SwiftKitExample#52
Merged
Conversation
Further progress on cleaning up the build. We're still having issues
with various runtime issues but this gets us to a more understandable
separation of "what is a sample" and "what is the library". There's more
to be done before we can kill off `make` but this does quite some
progress.
- Sample apps "anything with a main()" have their own place; it used to
be very mixed up in the same target; together with the example lib
- `JavaKitSampleApp` there's a sample for javakit which uses the
`JavaKitExample` defined swift type
- `SwiftKitSampleApp` the jextract demo app, uses the
`ExampleSwiftLibrary`
- those JavaKitExample and ExampleSwiftLibrary could use further
moving out of `Sources/...` as they're example stuff, not "the
library" but I leave at this for now...
Running samples: ./gradlew Samples:SwiftKitSampleApp:run
(Samples:Name:run)
- `./gradlew test` does the jextract and whatever the sample apps need
- make is still around; didn't hook up any of the javakit generation
- generated sources no longer in wrong directory; `src/generated/`... as
the usual convention in Java land (and not committed)
ktoso
force-pushed
the
wip-build-cleanup
branch
from
98038f9 to
53b811a
Compare
Collaborator
Author
|
With disabled tests per platform challenges, but at least we have our first green CI run 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further progress on cleaning up the build. We're still having issues with various runtime issues but this gets us to a more understandable separation of "what is a sample" and "what is the library". There's more to be done before we can kill off
makebut this does quite some progress.JavaKitSampleAppthere's a sample for javakit which uses theJavaKitExampledefined swift typeSwiftKitSampleAppthe jextract demo app, uses theExampleSwiftLibrarySources/...as they're example stuff, not "the library" but I leave at this for now...Running samples: ./gradlew Samples:SwiftKitSampleApp:run (Samples:Name:run)
./gradlew testdoes the jextract and whatever the sample apps needsrc/generated/... as the usual convention in Java land (and not committed)Tests status:
but there's some disabled tests on either platforms... We really should get nightly toolchains so we can kill off the
nmthings with #27 and I'm working to figure that out.