Fix glue functions as public in JNI mode#520
Merged
Merged
Conversation
ktoso
approved these changes
Jan 15, 2026
Collaborator
ktoso
left a comment
There was a problem hiding this comment.
Yeah, the missing public would be able to cause such a thing. Thanks for the pull request!
Contributor
Author
|
My very tiny library worked fine with this, swift-java/Sources/SwiftJava/JNI.swift Line 57 in 1c73ff0 |
Collaborator
|
I would not mind making it public in abundance if caution. |
Contributor
Author
|
Now
|
Collaborator
|
Thank you! this did make me think that it likely was necessaey to begin with. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In release builds (JNI mode), Java-linked Swift functions were being stripped from the dynamic library, It might be because of dead code elimination.
I have added the
publicmodifier to these functions to match the behavior of FFM mode and ensure they are properly exported.