Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request introduces significant improvements to the feature flag client, focusing on enhanced remote evaluation support, improved error handling, and updated documentation and tests to reflect these changes. The core logic for remote criteria evaluation has been added, along with new error types and result handling structures. The usage examples and tests have been updated to use the new error-aware API.
Remote criteria evaluation and error handling:
remote.gowith logic for remote criteria evaluation, including token management, criteria checks, and HTTP client configuration. This enables secure and robust remote feature flag evaluation.errors.go(RemoteError,RemoteAuthError,RemoteCriteriaError) for clearer error management during remote operations.ResultDetailstruct inresult.goto encapsulate detailed results of feature evaluation, including metadata and reasons.Switcher API enhancements:
Switchermethods inswitcher.goto support error returns:IsOn()andIsOnWithDetails()now return errors, and new methods likeCheckValue,Prepare, andappendFilteredEntriesprovide more flexible criteria management.Clientfor authentication token management.Documentation and test updates:
README.mdto handle errors returned byIsOn()and related methods, ensuring best practices are followed in client usage.switcher_test.goto cover new error scenarios, token preparation, and entry filtering logic.These changes collectively make the client more robust, secure, and user-friendly, especially in remote and error-prone environments.