Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request introduces improvements to the HTTP client management and request handling logic in the
clientpackage. The main changes add thread-safe, lazy initialization and caching for the HTTP client, and ensure safer handling ofnilentries in request payloads.HTTP client management improvements:
httpClientMu) and a cached HTTP client field (httpClient_) to theClientstruct to support thread-safe, lazy initialization and reuse of thehttp.Clientinstance. (client.goclient.goR21-R23)httpClient()method to use the mutex and cache, ensuring only one HTTP client is created and reused across requests. (remote.go[1] [2]net/httppackage to support the new HTTP client logic. (client.goclient.goR4)Request payload safety:
checkCriteriamethod to ensure that theentriesfield in the request payload is always a valid (non-nil) slice, preventing potential issues when the field isnil. (remote.goremote.goR97-R106)