Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request introduces local snapshot support for evaluating feature switches, enabling offline and deterministic switcher evaluations based on local JSON files. It adds snapshot loading, local criteria evaluation logic, new error types, and comprehensive tests to ensure correctness for various scenarios.
Snapshot support and local evaluation:
Snapshotstruct and related types insnapshot.goto represent local feature state, with logic for loading, creating, and reading snapshot files.Clientstruct and provided new methods:LoadSnapshot,SnapshotVersion, and internal state management for snapshots inclient.go. [1] [2]resolver.goto determine switcher state based on the loaded snapshot, supporting value and network strategies, group and config activation, and relay restrictions.Switcherlogic inswitcher.goto use local snapshot evaluation when in local mode, added support for network-based criteria, and improved criteria entry handling. [1] [2] [3] [4]Error handling:
LocalCriteriaErrortype inerrors.goto distinguish local evaluation errors from remote errors, with corresponding error construction helpers.Testing:
local_test.gocovering snapshot loading, error cases, and various switcher evaluation scenarios using local snapshots.