Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request replaces snapshot_lifecycle with segregated exclusive and independent features for watching snapshot files, updating and loading.
Snapshot Auto-Update Feature:
snapshot_auto_updater.gomodule, which implements a background goroutine to periodically check for and apply remote snapshot updates, with scheduling and termination controls.ScheduleSnapshotAutoUpdateandTerminateSnapshotAutoUpdateto control auto-updating, both globally and on a per-client basis.snapshot_auto_updater_test.go, covering scheduling, callback invocation, update application, and termination.Remote API Integration and Client Enhancements:
CheckSnapshot,checkSnapshotVersion, andresolveSnapshotto interact with remote endpoints for snapshot status checking and retrieval. Added relevant response types and improved error handling for remote operations. [1] [2] [3]client.gofor determining when to check snapshots and for loading snapshots from files.Testing and Cleanup:
local_test.goto streamline the test suite in light of the new auto-update logic.Development Environment and Build Improvements:
fmtcommand to theMakefilefor code formatting and updated.PHONYtargets. [1] [2].devcontainer/Dockerfileand renamed the main service indocker-compose.ymlfor clarity. [1] [2]Miscellaneous:
Overall, these changes introduce a robust, test-covered mechanism for keeping client snapshots up-to-date automatically, while also improving developer ergonomics and code structure.