Updated ensime bindings to better fit with spacemacs#600
Updated ensime bindings to better fit with spacemacs#600bjarkevad wants to merge 1 commit intosyl20bnr:developfrom
Conversation
|
I like this. +1 |
There was a problem hiding this comment.
It is not in the conventions for now but the refactoring is planned to be on SPC m R instead of SPC m r.
|
I will wait a bit before merging it because I have to read the doc of each command and maybe play a bit with them in order to make them match with what we have in the other layers. Each new added tool is a great opportunity to discover new commands so this PR has a lot of value. Thank you ! |
|
Thanks for the feedback! |
38c2569 to
ef0e970
Compare
ef0e970 to
490adee
Compare
There was a problem hiding this comment.
I've added a new function which generates an .ensime and reloads ensime, which is useful when the project changes. Sometimes it's also necessary to rm -r .ensime_cache in the project root to force ensime to notice changes to e.g. dependencies.
|
Excellent PR ! 👍 ❤️ Cherry-picked into |
|
@bjarkevad, forgot to mention that I decided to put refactoring bindings under CC @bru We have 2 solutions:
I would go with 1) to keep consistency with |
|
Considered the fact that currently the ruby layer has 1 refactor command vs
|
|
|
|
Essentially any view in a rails project.
|
|
I never thought about this... this is a big limitation, Extending |
I've updated the bindings for ensime so they fit a bit better with spacemacs, but rather than following spacemacs convetions I've pretty much just translated ensime's default bindings from
C-c C-{X} somethingtospc m {X} something.I'm not sure if this is the best idea, but it makes switching from normal emacs + ensime to spacemacs + ensime easier.