Skip to content

Clarify context of SCIF app implementation - #4

Merged
dtrudg merged 1 commit into
sylabs:masterfrom
dtrudg:scif-clarify
May 19, 2021
Merged

Clarify context of SCIF app implementation#4
dtrudg merged 1 commit into
sylabs:masterfrom
dtrudg:scif-clarify

Conversation

@dtrudg

@dtrudg dtrudg commented May 14, 2021

Copy link
Copy Markdown
Member

Description of the Pull Request (PR):

Claritfy the context of the SCIF app implementation.

Initial minimal context setting here... Having read through where/how we mention apps, and given that the SCIF implementation is and continues to be a maintained and tested part of the core code, I think we should go further toward having a separate top-level section that is more complete. We should then reference it from the usage / build / services pages.

Would love to get your thoughts @vsoch on whether this is a decent start, so we are at least guaranteed to be somewhat improved for the 3.8.0 release.

This fixes or addresses the following GitHub issues:

@dtrudg dtrudg added this to the 3.8.0 milestone May 14, 2021
@dtrudg dtrudg self-assigned this May 14, 2021

@vsoch vsoch left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you for the quick fixes @dtrudg.

Comment thread definition_files.rst Outdated
Comment thread definition_files.rst Outdated
@dtrudg
dtrudg requested a review from a team May 19, 2021 18:34

@tri-adam tri-adam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dtrudg and @vsoch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants