Skip to content

Do not hardcode /nix/store path#40

Merged
fabpot merged 1 commit into
symfony-cli:mainfrom
Kocal:main
Jul 3, 2026
Merged

Do not hardcode /nix/store path#40
fabpot merged 1 commit into
symfony-cli:mainfrom
Kocal:main

Conversation

@Kocal

@Kocal Kocal commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@tucksaun suggested me to not hardcode /nix/store path, since it can be modified IIUC.

The command nix eval --raw --expr builtins.storeDir gives me the Nix store path:

symfony-cli on  nix-no-hardcode via 🐳 orbstack via 🐹 v1.26.4 took 4s
✗ nix eval --raw --expr builtins.storeDir
/nix/store%

@tucksaun tucksaun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabpot

fabpot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Do we need to fallback to /nix/store if nix eval fails?

@tucksaun

tucksaun commented Jul 3, 2026

Copy link
Copy Markdown
Member

Do we need to fallback to /nix/store if nix eval fails?

we could but I dont think it's worth it: if nix eval fails the user probably has bigger problems than being able to run php using the Symfony CLI

@fabpot

fabpot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Thank you @Kocal.

@fabpot fabpot merged commit cd7c5ba into symfony-cli:main Jul 3, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants