-
Notifications
You must be signed in to change notification settings - Fork 15
ES-999054: Prepare Demo Samples and Update User Guide with API Reference for Row Drag-and-Drop in WinForms SfDataGrid #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: hotfix/hotfix-v32.1.19
Are you sure you want to change the base?
Conversation
|
Build Status: INPROGRESS 🔃 |
|
CI Status: FAILURE ❌ |
|
Build Status: INPROGRESS 🔃 |
|
CI Status: FAILURE ❌ |
|
Build Status: INPROGRESS 🔃 |
|
CI Status: FAILURE ❌ |
WindowsForms/DataGrid/DragAndDrop.md
Outdated
|
|
||
| ## Row Drag and Drop | ||
| WinForms DataGrid allows drag and drop the rows within and between controls by setting the **AllowDraggingRows** and **AllowDrop** property as true. It is also possible to drag and drop the rows between datagrids. SfDataGrid allows dropping rows when **AllowDrop** is true and allows dragging when **AllowDraggingRows** is true. | ||
| WinForms DataGrid allows drag and drop the rows within and between controls by setting the [AllowDraggingRows](https://help.syncfusion.com/cr/windowsforms/Syncfusion.WinForms.DataGrid.SfDataGrid.html#Syncfusion_WinForms_DataGrid_SfDataGrid_AllowDraggingRows) and [AllowDrop](https://help.syncfusion.com/cr/windowsforms/Syncfusion.WinForms.DataGrid.SfDataGrid.html#Syncfusion_WinForms_DataGrid_SfDataGrid_AllowDrop) property as true. It is also possible to drag and drop the rows between datagrids. SfDataGrid allows dropping rows when [AllowDrop](https://help.syncfusion.com/cr/windowsforms/Syncfusion.WinForms.DataGrid.SfDataGrid.html#Syncfusion_WinForms_DataGrid_SfDataGrid_AllowDrop) is true and allows dragging when [AllowDraggingRows](https://help.syncfusion.com/cr/windowsforms/Syncfusion.WinForms.DataGrid.SfDataGrid.html#Syncfusion_WinForms_DataGrid_SfDataGrid_AllowDraggingRows) is true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just bold the AllowDraggingRows and AllowDrop property for the second time. Link need to be provided only once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the content so that the first occurrence of AllowDraggingRows and AllowDrop includes the link. Subsequent mentions are now bolded without repeating the link.
WindowsForms/DataGrid/DragAndDrop.md
Outdated
| #### Disable dragging of certain rows in WinForms DataGrid | ||
|
|
||
| You can restrict the dragging of certain rows in SfDataGrid by using the **GridRowDragDropController.DragStart event**. | ||
| You can restrict the dragging of certain rows in SfDataGrid by using the [GridRowDragDropController.DragStart event](https://help.syncfusion.com/cr/windowsforms/Syncfusion.WinForms.DataGrid.Interactivity.RowDragDropController.html#Syncfusion_WinForms_DataGrid_Interactivity_RowDragDropController_DragStart). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link should only be applicable for GridRowDragDropController.DragStart. Mistakenly event also placed inside the bracket. Check and resolve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have corrected the link to apply only to GridRowDragDropController.DragStart and moved the event outside the brackets.
WindowsForms/DataGrid/DragAndDrop.md
Outdated
| #### Disable dropping over certain rows in WinForms DataGrid | ||
|
|
||
| You can restrict the dropping the records in certain rows in SfDataGrid by using the **GridRowDragDropController.Drop event**. | ||
| You can restrict the dropping the records in certain rows in SfDataGrid by using the [GridRowDragDropController.Drop event](https://help.syncfusion.com/cr/windowsforms/Syncfusion.WinForms.DataGrid.Interactivity.RowDragDropController.html#Syncfusion_WinForms_DataGrid_Interactivity_RowDragDropController_Drop). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below comment is applicable for this
https://github.com/syncfusion-content/windowsforms-docs/pull/1377/files#r2627257536
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have corrected the link to apply only to GridRowDragDropController.Drop and moved the event outside the brackets.
WindowsForms/DataGrid/DragAndDrop.md
Outdated
| #### Disable the default drag UI | ||
|
|
||
| You can disable the draggable popup by setting the ShowDragUI as false in the DragOver event of **GridRowDragDropController.DragOver event**. | ||
| You can disable the draggable popup by setting the ShowDragUI as false in the DragOver event of [GridRowDragDropController.DragOver event](https://help.syncfusion.com/cr/windowsforms/Syncfusion.WinForms.DataGrid.Interactivity.RowDragDropController.html#Syncfusion_WinForms_DataGrid_Interactivity_RowDragDropController_DragOver). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below comment is applicable for this
https://github.com/syncfusion-content/windowsforms-docs/pull/1377/files#r2627257536
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have corrected the link to apply only to GridRowDragDropController.DragOver and moved the event outside the brackets.
WindowsForms/DataGrid/DragAndDrop.md
Outdated
|
|
||
| ### Row drag and drop between DataGrid and ListView | ||
|
|
||
| To perform dragging between the ListView and SfDataGrid, by using the [GridRowDragDropController.Drop event](https://help.syncfusion.com/cr/windowsforms/Syncfusion.WinForms.DataGrid.Interactivity.RowDragDropController.html#Syncfusion_WinForms_DataGrid_Interactivity_RowDragDropController_Drop) and you must set the `AllowDrop` property as true in the `ListView` while doing the drag and drop operation from `SfDataGrid` with `ListView` control. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below comment is applicable for this
https://github.com/syncfusion-content/windowsforms-docs/pull/1377/files#r2627257536
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have corrected the link to apply only to GridRowDragDropController.Drop and moved the event outside the brackets.
ChidanandMurugaiah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address the concerns and let me know
|
Build Status: INQUEUE 🕒 |
|
Build Status: INPROGRESS 🔃 |
|
@ChidanandMurugaiah , I have addressed the review concerns. |
|
CI Status: FAILURE ❌ |
|
Build Status: INPROGRESS 🔃 |
|
CI Status: FAILURE ❌ |
Description
Task Details ES-999054