Skip to content

Bitkit Core support for hardware wallet activities #1029

Description

@ovitrif

Part of #998.

Blocked by synonymdev/bitkit-core#112 and synonymdev/bitkit-core#113.

Scope

Use Bitkit Core wallet-scoped activity support for hardware-wallet watcher activity, so hardware transactions can reuse normal activity capabilities where appropriate:

  • Stable detail loading.
  • Inputs/outputs via Bitkit Core transaction details fetched from the configured Electrum/electrs backend.
  • Tag add/remove support.
  • Unified activity listing so hardware-wallet activity and normal Bitkit wallet activity can be returned in the same sorted list.
  • Activity Detail should show tags and inputs/outputs for hardware-wallet activity instead of the current watch-only fallback.

App integration

After the Core work lands:

  • Use the current Core activity model shape from refactor: move walletId to v2 activity models bitkit-core#112.
  • Use the shared wallet id scheme for hardware-wallet activity. Do not generate ad hoc app-only wallet ids in this repo.
  • Keep wallet id handling behind the app's typed wallet-id model/helpers, not raw string literals passed around the codebase.
  • Persist hardware watcher activities and transaction details through Core with the derived hardware wallet id.
  • Read Activity Detail data through Core using the activity's wallet id.
  • Add/remove tags through Core using the activity's wallet id.
  • Use Core global list/search only where the UI intentionally merges the normal Bitkit wallet with paired hardware wallets.
  • Use wallet-scoped Core calls for detail, txid lookup, tags, seen state, and deletion.

Device removal

Hardware activity visibility must stay scoped to paired hardware-wallet identities:

  • Removing a paired device deletes that wallet's hardware activity/details/tag metadata from Bitkit Core.
  • Re-adding the same wallet should rebuild visible history from the watcher and fetch transaction details again as needed.
  • Activity id and txid collisions across wallet ids must stay scoped.

Out of scope

Backup/VSS migration for Core-owned activity data is tracked in #1046 and blocked by synonymdev/bitkit-core#113.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No fields configured for Task.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions