-
Notifications
You must be signed in to change notification settings - Fork 3
fix: align widget preview defaults with ios #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
app/src/test/java/to/bitkit/ui/screens/widgets/WidgetSizeDraftTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| package to.bitkit.ui.screens.widgets | ||
|
|
||
| import kotlinx.coroutines.ExperimentalCoroutinesApi | ||
| import kotlinx.coroutines.flow.MutableStateFlow | ||
| import kotlinx.coroutines.flow.first | ||
| import kotlinx.coroutines.launch | ||
| import kotlinx.coroutines.test.advanceUntilIdle | ||
| import org.junit.Before | ||
| import to.bitkit.data.WidgetsData | ||
| import to.bitkit.models.WidgetSize | ||
| import to.bitkit.models.WidgetType | ||
| import to.bitkit.models.WidgetWithPosition | ||
| import to.bitkit.test.BaseUnitTest | ||
| import kotlin.test.Test | ||
| import kotlin.test.assertEquals | ||
|
|
||
| @OptIn(ExperimentalCoroutinesApi::class) | ||
| class WidgetSizeDraftTest : BaseUnitTest() { | ||
|
|
||
| private val widgetsData = MutableStateFlow(WidgetsData(widgets = emptyList())) | ||
|
|
||
| @Before | ||
| fun setUp() { | ||
| widgetsData.value = WidgetsData(widgets = emptyList()) | ||
| } | ||
|
|
||
| @Test | ||
| fun `unsaved widget defaults to small for wide types`() = test { | ||
| val draft = WidgetSizeDraft(backgroundScope, WidgetType.PRICE, widgetsData) | ||
| val collector = backgroundScope.launch { draft.size.collect {} } | ||
|
|
||
| advanceUntilIdle() | ||
|
|
||
| assertEquals(WidgetSize.SMALL, draft.size.first()) | ||
| collector.cancel() | ||
| } | ||
|
|
||
| @Test | ||
| fun `saved widget reflects persisted size`() = test { | ||
| widgetsData.value = WidgetsData( | ||
| widgets = listOf( | ||
| WidgetWithPosition(type = WidgetType.PRICE, position = 0, size = WidgetSize.WIDE), | ||
| ), | ||
| ) | ||
| val draft = WidgetSizeDraft(backgroundScope, WidgetType.PRICE, widgetsData) | ||
| val collector = backgroundScope.launch { draft.size.collect {} } | ||
|
|
||
| advanceUntilIdle() | ||
|
|
||
| assertEquals(WidgetSize.WIDE, draft.size.first()) | ||
| collector.cancel() | ||
| } | ||
|
|
||
| @Test | ||
| fun `user draft overrides saved size`() = test { | ||
| widgetsData.value = WidgetsData( | ||
| widgets = listOf( | ||
| WidgetWithPosition(type = WidgetType.FACTS, position = 0, size = WidgetSize.SMALL), | ||
| ), | ||
| ) | ||
| val draft = WidgetSizeDraft(backgroundScope, WidgetType.FACTS, widgetsData) | ||
| val collector = backgroundScope.launch { draft.size.collect {} } | ||
|
|
||
| advanceUntilIdle() | ||
| draft.set(WidgetSize.WIDE) | ||
|
|
||
| advanceUntilIdle() | ||
|
|
||
| assertEquals(WidgetSize.WIDE, draft.size.first()) | ||
| collector.cancel() | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| New widgets now open on compact size in the preview carousel, matching iOS, and the add-widgets list keeps its scroll position when navigating back. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.