feat: surface typed Trezor PIN-failure errors via trezor-connect-rs 0.3.3#106
Merged
Merged
Conversation
….3.3 trezor-connect-rs 0.3.3 maps protocol Failure codes to typed DeviceError variants, so a wrong-PIN failure now surfaces as TrezorError::InvalidPin instead of a generic device error. The existing From impl already maps these variants; no conversion-logic change is needed and the FFI surface is unchanged. - Bump trezor-connect-rs 0.3.2 -> 0.3.3 (non-iOS and iOS targets). - Add tests starting from raw FailureType codes (via the new public DeviceError::from_failure) asserting they reach the typed errors: 7 -> InvalidPin, 6 -> PinCancelled, 5 -> PinRequired, 4 -> UserCancelled, 99 -> generic DeviceError (code + message preserved).
Collaborator
Author
|
Will create a new release for this PR once approved unless one is needed sooner. |
ovitrif
approved these changes
Jun 22, 2026
ovitrif
left a comment
ovitrif
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks.
Collaborator
Author
|
Release created here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #105
Description
trezor-connect-rs0.3.3maps protocolFailurecodes to typedDeviceErrorvariants, so a wrong-PIN failure now surfaces asTrezorError::InvalidPininstead of a generic device error. The existing From impl already maps these variants; no conversion-logic change is needed and the FFI surface is unchanged.trezor-connect-rs 0.3.2->0.3.3(non-iOS and iOS targets).FailureTypecodes (via the new publicDeviceError::from_failure) asserting they reach the typed errors:7->InvalidPin,6->PinCancelled,5->PinRequired,4->UserCancelled,99-> genericDeviceError(code + message preserved).