[codex] Add Pubky Ring auth callbacks#530
Conversation
piotr-iohk
left a comment
There was a problem hiding this comment.
Verified success, cancel and error callbacks. All work as expected.
Note the callbacks are available in 0.28 pubky-ring version which is in TestFlight.
Tested also with 0.27 pubky-ring (without callbacks). The flow works as expected as well (obv no callbacks, also no regressions).
|
This might be un-related to this change. Observed few times after a moment of inactivity in Bitkit (with pubky-ring profile imported): bitkit_logs_2026-04-29_09-35-29.zip
After that the profile is disconnected. Screen.Recording.2026-04-29.at.11.32.14.mov |
jvsena42
left a comment
There was a problem hiding this comment.
Tested: approve and deny options. both returned no Bitkit app
This comment has been minimized.
This comment has been minimized.
|
Retesting after recent updates. I think there is some issue with
See the recodring - first is "Deny" then Authorization attempt on broken pubky. Screen.Recording.2026-04-30.at.14.09.13.mov |
|
@piotr-iohk can you please attach logs from it? |
|
|
Checked the logs. This looks like a Pubky Ring callback encoding issue. Bitkit sends callback URLs with a nonce value, e.g.
So the I also fixed Bitkit so malformed cancel/error callbacks no longer leave the UI stuck on “Waiting for authorization.” We still treat those callbacks as untrusted: malformed success is ignored, and malformed error does not display attacker-controlled text. |
|
Created issue on pubky-ring: |
piotr-iohk
left a comment
There was a problem hiding this comment.
LGTM, my previous issues no longer observed.
16d3ab9
into
codex/pr-527-contact-fixes
|
@ben-kaufman just seen some issues already fixed here and realized this didn't get into |
* feat: add Pubky Ring auth callbacks * Update CHANGELOG with Pubky Ring auth callbacks * fix: preserve pubky session after canceled auth * fix: validate pubky auth callbacks * fix: recover from malformed pubky callbacks
* feat: add Pubky Ring auth callbacks * Update CHANGELOG with Pubky Ring auth callbacks * fix: preserve pubky session after canceled auth * fix: validate pubky auth callbacks * fix: recover from malformed pubky callbacks
* feat: add Pubky Ring auth callbacks * Update CHANGELOG with Pubky Ring auth callbacks * fix: preserve pubky session after canceled auth * fix: validate pubky auth callbacks * fix: recover from malformed pubky callbacks

Summary
x-success,x-cancel,x-error, andx-source=Bitkitcallback parameters to generated auth URLs.Why
Pubky Ring now supports custom callback URLs. Adding these parameters lets Ring return users to Bitkit after approval, cancellation, or error instead of leaving the app switch flow hanging.
Validation
git diff --checkswiftformatwas run on the touched Swift files.xcodebuildwas attempted, but it is blocked by the existing externalVssRustClientFfi/Uniffigenerated bindings issue.