feat: hardware wallet detail screen#611
Draft
jvsena42 wants to merge 3 commits into
Draft
Conversation
Member
Author
|
Waiting for #605 merge to open this branch for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #589
This PR adds a detail screen for paired hardware wallets. Tapping a device's tile on the home screen now opens a Savings/Spending-style overview of that watch-only wallet instead of a "Coming Soon" notice.
Description
This is the iOS port of synonymdev/bitkit-android#1022. iOS already had the watch-only data layer (per-device
deviceIds,removeDevice,walletsLoaded, blue hardware activity icons, andwalletId-scoped activity queries), so this PR is mainly the detail screen and its navigation wiring.Linked Issues/Tasks
Screenshot / Video
with-activities.mov
delete.mov
QA Notes
OBS: Only tested with emulator
Manual Tests
regression:Home, Savings, Spending, and All Activity -> bottom Send/Scan/Receive bar visible on each.Automated Checks
xcodebuild -workspace Bitkit.xcodeproj/project.xcworkspace -scheme Bitkit -configuration Debug -destination 'platform=iOS Simulator,id=<iPhone 16>' ONLY_ACTIVE_ARCH=YES build(concrete simulator UDID +ONLY_ACTIVE_ARCH=YESbecause the Rust xcframeworks are arm64-only).BitkitTests/HwWalletManagerTests(29 tests) — existing coverage forremoveDevice(stops watchers, deletes activities) and forget-via-update. No new tests added because the new code is SwiftUI view orchestration over the already-testedHwWalletManager.removeDeviceandTrezorManager.forgetDevice.node scripts/validate-translations.jscould not run locally (missingglobdependency / nopackage.jsonin this checkout); the added English keys are well-formed.