Skip to content

Save battery thresholds to flash - #498

Merged
crawfxrd merged 2 commits into
masterfrom
save-bct
Nov 26, 2024
Merged

Save battery thresholds to flash#498
crawfxrd merged 2 commits into
masterfrom
save-bct

Conversation

@crawfxrd

@crawfxrd crawfxrd commented Aug 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Make battery thresholds persistent by saving them in flash space. This allows configuring them after EC reset (system powered-off, unplugged) but before any system firmware or OS policy can be applied.

As part of this, the dynamic keymap is moved from the hard-coded address of 0x1FC00 to "the last sector"; Models with 256 KiB flash (CONFIG_EC_FLASH_SIZE_256K=y) will lose their layout and need to reconfigure it.

Test

  • When not configured, default values (90, 100) are used across multiple EC resets
  • When configured, the profile/custom values are used across multiple EC resets
    • If flash is dumped, the values are present in the ROM image

Check values with:

  • system76-power charge-thresholds
  • cat /sys/class/power_supply/BAT0/charge_control_{start,end}_threshold

jackpot51
jackpot51 reviewed Aug 23, 2024
View reviewed changes
Comment thread src/board/system76/common/battery.c Outdated
jackpot51
jackpot51 reviewed Aug 23, 2024
View reviewed changes
Comment thread src/board/system76/common/battery.c
crawfxrd
crawfxrd commented Aug 23, 2024
View reviewed changes
Comment thread src/board/system76/common/acpi.c
@crawfxrd
Save dynamic keymap at last sector
2ff7ec1 
With the use of 256 KiB flash chips, the hard-coded address of 0x1FC00
may no longer be "the last sector".

Signed-off-by: Tim Crawford <tcrawford@system76.com>
jackpot51
jackpot51 previously approved these changes Nov 22, 2024
View reviewed changes
@crawfxrd

crawfxrd commented Nov 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Writing to flash works.

0003f800: 54 42 56 5a ff ff ff ff ff ff ff ff ff ff ff ff  TBVZ............

Reading it back does not.

$ cat /sys/class/power_supply/BAT0/charge_control_{start,end}_threshold
1
1

And I don't know why. And now that I've said it, it's very obvious.

@crawfxrd
Save battery thresholds at second-to-last sector
32eaa08 
Make battery thresholds persistent by saving them in flash space. This
allows configuring them after EC reset (system powered-off, unplugged)
but before any system firmware or OS policy can be applied.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
crawfxrd marked this pull request as ready for review November 25, 2024 23:22
@crawfxrd
crawfxrd requested review from a team and jackpot51 November 25, 2024 23:23
@leviport leviport self-assigned this Nov 26, 2024
leviport
leviport approved these changes Nov 26, 2024
View reviewed changes

@leviport leviport left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on darp10-b, and this seems to be working great. The thresholds I set persist through multiple EC resets. Very nice!

@crawfxrd
crawfxrd merged commit 85da2d2 into master Nov 26, 2024
@crawfxrd
crawfxrd deleted the save-bct branch November 26, 2024 22:17
@crawfxrd crawfxrd linked an issue Dec 13, 2024 that may be closed by this pull request
Charging thresholds don't persist through an EC reset #128
Closed
@crawfxrd crawfxrd mentioned this pull request Dec 13, 2024
Closed
@jacobgkau jacobgkau mentioned this pull request Apr 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackpot51 jackpot51 jackpot51 approved these changes
@leviport leviport leviport approved these changes

Assignees

@leviport leviport

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Charging thresholds don't persist through an EC reset

3 participants

@crawfxrd @jackpot51 @leviport