Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a kind of annoying bug I've encountered in the mod:
When
sneak+wrencha single side catwalk railing the block is updated to[north=false,south=false,west=false,east=false]instead of breaking the block. This causes the block to not be empty, and it becomes impossible for a player to place a block there.Only solution was placing a block attached to the incriminated block. This will trigger neighbour update and the block gets removed.
This is now solved with a simple if check: when
sneak+wrench, before any check, if the block only has one single side, the interaction gets handled by super (IWrenched). It makes sense that it doesnt execute rest of the logic because theres no need to check which side of the railing we are checking to remove it, as there's only one available.Hope this commit can improve the mod quality ;)